Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependents 71248 | Step 3: Remove dependents who have died (Form 686) #31896

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

Midge-dev
Copy link
Contributor

@Midge-dev Midge-dev commented Sep 11, 2024

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to Summary and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

If the folder you changed contains a manifest.json, search for its entryName in the content-build registry.json (the entryName there will match).

If an entry for this folder exists in content-build and you are:

  1. Deleting a folder:

    1. First search vets-website for all instances of the entryName in your manifest.json and remove them in a separate PR. Look particularly for references in src/applications/static-pages/static-pages-entry.js and src/platform/forms/constants.js. If you do not do this, other applications will break!
      • Add the link to your merged vets-website PR here
    2. Then, Delete the application entry in registry.json and merge that PR before this one
      • Add the link to your merged content-build PR here
  2. Renaming or moving a folder: Update the entry in the registry.json, but do not merge it until your vets-website changes here are merged. The content-build PR must be merged immediately after your vets-website change is merged in to avoid CI errors with content-build (and Tugboat).

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Separated questions out into several pages
  • Added Array builder list and loop pattern
  • Refactored using latest platform web-component patterns
  • Updated unit and E2E tests
  • Added updated copy

Related issue(s)

Testing done

  • Manual
  • Unit / E2E
  • Axe

What areas of the site does it impact?

  • /view-change-dependents/add-remove-form-21-686c-v2/

All of this work is behind the flipper va_dependents_v2 and will be incrementally rolled out

Figma

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/dependents-71248-remove-deceased/main September 11, 2024 21:59 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/dependents-71248-remove-deceased/main September 13, 2024 19:27 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/dependents-71248-remove-deceased/main September 16, 2024 20:52 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/dependents-71248-remove-deceased/main September 16, 2024 22:29 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/dependents-71248-remove-deceased/main September 18, 2024 18:09 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/dependents-71248-remove-deceased/main September 19, 2024 21:06 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/dependents-71248-remove-deceased/main September 20, 2024 19:17 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/dependents-71248-remove-deceased/main September 23, 2024 18:51 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/dependents-71248-remove-deceased/main September 24, 2024 20:02 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/dependents-71248-remove-deceased/main September 30, 2024 20:55 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/dependents-71248-remove-deceased/main October 1, 2024 22:02 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/dependents-71248-remove-deceased/main October 1, 2024 22:40 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/dependents-71248-remove-deceased/main October 2, 2024 17:53 Inactive
@Midge-dev Midge-dev added the dependents-benefits Label used for Pull Requests that impact Add/Remove Dependents claims (686c/674) label Oct 2, 2024
@Midge-dev Midge-dev changed the title Init Dependents 71248 | Step 3: Remove deponents who have died (Form 686) Oct 2, 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generateTransition helper added for other active devs

@@ -103,7 +103,7 @@ export {
export function customTransformForSubmit(formConfig, form) {
const payload = cloneDeep(form);
// manually delete view:confirmEmail, since in our case we actually want the other view fields
delete payload.data.veteranContactInformation['view:confirmEmail'];
// delete payload.data.veteranContactInformation['view:confirmEmail'];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temp removing until submission rework

@va-vfs-bot va-vfs-bot temporarily deployed to master/dependents-71248-remove-deceased/main October 2, 2024 18:31 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/dependents-71248-remove-deceased/main October 2, 2024 18:40 Inactive
@Midge-dev Midge-dev changed the title Dependents 71248 | Step 3: Remove deponents who have died (Form 686) Dependents 71248 | Step 3: Remove dependents who have died (Form 686) Oct 2, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to master/dependents-71248-remove-deceased/main October 2, 2024 22:03 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/dependents-71248-remove-deceased/main October 3, 2024 17:15 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependents-benefits Label used for Pull Requests that impact Add/Remove Dependents claims (686c/674)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants